Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endianness is being swapped incorrectly #1963

Closed
aarond10 opened this issue Jan 10, 2023 · 8 comments
Closed

Endianness is being swapped incorrectly #1963

aarond10 opened this issue Jan 10, 2023 · 8 comments

Comments

@aarond10
Copy link
Contributor

The byte swap of flowinfo and scope_id here seems wrong and appears to have broken my project.

Pull request forthcoming with a fix.
@aarond10 aarond10 mentioned this issue Jan 10, 2023
Merged
@aarond10
Copy link
Contributor Author

@khuey, can you take a look at this one? It looks like you added this code back in May.

@khuey
Copy link
Contributor

khuey commented Jan 12, 2023

Yeah, the existing code is wrong and the fix is correct, these extra fields are in host byte order.

bors bot added a commit that referenced this issue Jan 13, 2023
@bors @aarond10
Merge #1964
c5d6732 
1964: Fix endian swap on SocketAddrV6. r=asomers a=aarond10

This is a bug. flowinfo and scope_id should not be byte swapped here.

See also #1963.

Co-authored-by: Aaron Drew <aarond10@gmail.com>
@aarond10
Copy link
Contributor Author

Thanks for merging the fix. How often are releases cut? I see the last one was November.

Is it possible to request a new minor release be pushed to cargo?
I'm working on a project that uses vendored crates and without a cargo release I'll have to maintain a fork until the next release in order to keep on working.

@aarond10
Copy link
Contributor Author

@asomers, could a new release be cut and pushed to crates.io?

@asomers
Copy link
Member

asomers commented Jan 17, 2023

Yes, this bug warrants a patch release. See #1974 .

@asomers
Copy link
Member

asomers commented Jan 18, 2023

0.26.2 released.

@asomers asomers closed this as completed Jan 18, 2023
@aarond10
Copy link
Contributor Author

Thanks! BTW, is there some back integration system? The master branch doesn't seem to have the #1974 change, only the r0.26 branch.

@asomers
Copy link
Member

asomers commented Jan 18, 2023

Yes, and the "system" is that we cherry-pick stuff manually. That way release 0.26.2 contains only bug fixes, not the new features that are in the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asomers @aarond10 @khuey