Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip ci] fix CHANGELOG formatting #1888

Merged
merged 1 commit into from Nov 29, 2022
Merged

[skip ci] fix CHANGELOG formatting #1888

merged 1 commit into from Nov 29, 2022

Conversation

asomers
Copy link
Member

@asomers asomers commented Nov 29, 2022

No description provided.

rtzoeller
rtzoeller approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@rtzoeller rtzoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Nov 29, 2022
@bors @asomers
Merge #1888
bdd3cb2 
1888: [skip ci] fix CHANGELOG formatting r=rtzoeller a=asomers



Co-authored-by: Alan Somers <asomers@gmail.com>
@rtzoeller
Copy link
Collaborator

Speaking of changelogs, @asomers how do you feel about me importing the patch release changelog notes into master once we're done with them?

We've been inconsistent with this in the past, and it makes it difficult to tell if a change was fixed in a given patch release - you have to navigate to the correct branch first.

@asomers
Copy link
Member Author

asomers commented Nov 29, 2022

Speaking of changelogs, @asomers how do you feel about me importing the patch release changelog notes into master once we're done with them?

We've been inconsistent with this in the past, and it makes it difficult to tell if a change was fixed in a given patch release - you have to navigate to the correct branch first.

Definitely. We should merge all of the patch releases' CHANGELOG notes. I'll try to do that now.

@asomers
Copy link
Member Author

asomers commented Nov 29, 2022

And bors doesn't understand [skip ci]. We'll have to merge manually.

bors r-

@bors
Copy link
Contributor

bors bot commented Nov 29, 2022

Canceled.

@asomers asomers merged commit eabcb48 into nix-rust:master Nov 29, 2022
@asomers asomers deleted the 0.26.0-CHANGELOG branch November 29, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtzoeller rtzoeller rtzoeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asomers @rtzoeller