Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test preadv and pwritev on more operating systems #1606

Merged
merged 3 commits into from Dec 15, 2021

Conversation

asomers
Copy link
Member

@asomers asomers commented Dec 15, 2021

This was an oversight from PR #1511. Also, update the OSX test environment for Big Sur. Big Sur is the first OSX version that supports preadv/pwritev

Big Sur is the first OSX version that supports preadv/pwritev
@asomers
Copy link
Member Author

asomers commented Dec 15, 2021

@rtzoeller do you know what's going on with the Dragonfly build?

@rtzoeller
Copy link
Collaborator

@rtzoeller do you know what's going on with the Dragonfly build?

@asomers I think it's related to this commit, but I'm not sure what the actual issue is. I'll look into it.

rust-lang/rust@e68887e

@rtzoeller
Copy link
Collaborator

@asomers I think rust-lang/rust@e68887e is just a bad change?

Per sys/socket.h on my system, the cmsgcred members defined in rust-lang/libc are correct, and the ones rustc is attempting to access are incorrect. The error message looks correct.

Will removing DragonFly from bors.toml let us submit this with a failing DragonFly build? That seems like the best short-term solution, since presumably rustc will eventually be fixed and this PR doesn't touch DragonFly in a special way.


@devnexen does rust-lang/rust@e68887e compile for you?

@asomers
Copy link
Member Author

asomers commented Dec 15, 2021

Will removing DragonFly from bors.toml let us submit this with a failing DragonFly build? That seems like the best short-term solution, since presumably rustc will eventually be fixed and this PR doesn't touch DragonFly in a special way.

It will, but then we'll be cursed with a nasty "failing build x" on our github page. What about pinning the toolchain to a specific nightly version for the Dragonfly build?

@rtzoeller
Copy link
Collaborator

Will removing DragonFly from bors.toml let us submit this with a failing DragonFly build? That seems like the best short-term solution, since presumably rustc will eventually be fixed and this PR doesn't touch DragonFly in a special way.

It will, but then we'll be cursed with a nasty "failing build x" on our github page. What about pinning the toolchain to a specific nightly version for the Dragonfly build?

I like that idea. Shall we try the commit/day prior to rust-lang/rust@e68887e?

@devnexen
Copy link
Contributor

In the meantime will fix the build on rust, thanks for spotting this.

@asomers
Copy link
Member Author

asomers commented Dec 15, 2021

Will removing DragonFly from bors.toml let us submit this with a failing DragonFly build? That seems like the best short-term solution, since presumably rustc will eventually be fixed and this PR doesn't touch DragonFly in a special way.

It will, but then we'll be cursed with a nasty "failing build x" on our github page. What about pinning the toolchain to a specific nightly version for the Dragonfly build?

I like that idea. Shall we try the commit/day prior to rust-lang/rust@e68887e?

Yeah, I'll try it.

@asomers asomers force-pushed the newer-osx2 branch 4 times, most recently from 3e1e6c7 to 4199697 Compare December 15, 2021 05:06
Newer rustc is broken on DragonflyBSD, probably by rust-lang/rust@e68887e
@asomers
Copy link
Member Author

asomers commented Dec 15, 2021

@rtzoeller should be good to review now

@rtzoeller
Copy link
Collaborator

bors r+

@nix-rust nix-rust deleted a comment from bors bot Dec 15, 2021
@bors bors bot merged commit a037c33 into nix-rust:master Dec 15, 2021
@asomers asomers deleted the newer-osx2 branch December 16, 2021 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants