Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wrapper for libc::mremap #1295

Closed
sporksmith opened this issue Sep 16, 2020 · 2 comments · Fixed by #1306
Closed

Add wrapper for libc::mremap #1295

sporksmith opened this issue Sep 16, 2020 · 2 comments · Fixed by #1306

Comments

@sporksmith
Copy link
Contributor

I need this in https://github.com/shadow/shadow. Happy to take a stab at it :)
@asomers
Copy link
Member

asomers commented Oct 3, 2020

Go ahead. Nix lives on the contributions of its users.

@sporksmith sporksmith mentioned this issue Oct 5, 2020
Merged
@sporksmith
Copy link
Contributor Author

@asomers - Thanks! #1306 is ready for review. CI is still running at the moment but the last commit just reverts it to an earlier state that already passed. (I'd tried enabling the mremap wrapper on Android, which failed CI, and then reverted that change)

@bors bors bot closed this as completed in 477743d Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add wrapper for mremap sporksmith/nix
2 participants
@asomers @sporksmith