Expose IP_PKTINFO Control Message on Android and iOS #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bltavares
changed the title
|
A nice, simple change. Could you please add a CHANGELOG entry, too? |
|
Sure thing :) |
|
Only one more problem: you'll have to rebase to fix the test failure. |
The commit nix-rust#1222 added the very useful Ipv4PktInfo to allow `sendmsg` to define the origin of the ip. Unfortunattely, it didn't add the struct to Android target devices as well. This commit adds the `target_os = "android"` checks on the same place to allow the compilation to work for the following archs tested: - `cross build --target aarch64-linux-android` - `cross build --target x86_64-linux-android` - `cross build --target armv7-linux-androideabi` Also introduces iOS to allow using on libs for those platforms
bltavares
force-pushed
the
sendmsg-pktinfo-android
branch
from
afe9300
to
0a97376
Compare
|
Sure thing - rebased and squashed all into a single commit |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit #1222 added the very
useful Ipv4PktInfo to allow
sendmsgto define the origin of the ip.Unfortunattely, it didn't add the struct to Android target devices as
well. This commit adds the
target_os = "android"andtarget_os =" ios"checks on the sameplace to allow the compilation to work for the following archs tested:
cross build --target aarch64-linux-androidcross build --target x86_64-linux-androidcross build --target armv7-linux-androideabicross build --target aarch64-apple-ioscross build --target x86_64-apple-ios