Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Become self-contained (cut the nixpkgs-fmt dependency) #340

Open
makoConstruct opened this issue Jul 24, 2023 · 1 comment
Open

Become self-contained (cut the nixpkgs-fmt dependency) #340

makoConstruct opened this issue Jul 24, 2023 · 1 comment

Comments

@makoConstruct
Copy link

The package seems to need nixpkgs-fmt to be installed in order for code formatting to work (related forum support thread). (This seems to be completely undocumented, which is another issue, but becoming self-contained would obviate that) I think it's clear that it would be better to ship a copy of nixpkgs-fmt in the vscode extension, as it's unlikely that the user will have it installed for any other purpose.

It seems that there is a wasm version of nixpkgs-fmt, and I believe vscode can run wasm (on any platform, of course), so we could use that?

Would a pull request, making this change, be accepted?

@jnoortheen
Copy link
Collaborator

Currently it supports using some Language Server backends (Nil, rnix...) and the nixpkgs-fmt executable for formatting. So packaging a formatter would mean it can format out of the box and for deeper integration one would still need a language server. But we can explore the possibility of packaging the formatter.

What would be the size of the wasm binary ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants