Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tendermint does not always create a decision when a proposal is received late. #2474

Open
nibhar opened this issue May 16, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@nibhar
Copy link
Member

nibhar commented May 16, 2024

Whenever Tendermint has a proposal and a precommit aggregation which holds 2f+1 votes for that proposal it should produce the proposal with the 2f+1 aggregation as proof as the decision value.

After adding a couple of tests on the nibhar/tendermint-tests branch it was observed that it does in fact not work when a proposal is received late.

For the scenario to not resolve there must be no subsequent updates to the aggregation in question which is the tested case on that branch. A subsequent update to the aggregation represents the it_accepts_late_polka test and will succeed.

The fix to this should be to check for decision criteria more proactively when receiving a proposal. It should be done in a way such that it does not matter whether or not the proposal was regularly received or as part of a response to a request.

Potentially related to #1533

@nibhar nibhar added the bug Something isn't working label May 16, 2024
@nibhar nibhar self-assigned this May 16, 2024
@styppo styppo added this to the Nimiq PoS Mainnet milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants