Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DoS in Discovery Handler #2458

Open
jsdanielh opened this issue May 9, 2024 · 0 comments · May be fixed by #2461
Open

DoS in Discovery Handler #2458

jsdanielh opened this issue May 9, 2024 · 0 comments · May be fixed by #2461
Assignees
@jsdanielh
Labels
HackerOne
Milestone
Nimiq PoS Mainnet

Comments

@jsdanielh
Copy link
Contributor

Link: https://hackerone.com/reports/2463319
Date: 2024-04-15 08:36:39 UTC
By: d0nut
Weakness: HTTP DoS

Details:

Summary

A malicious peer could wait until a victim peer entered the HandlerState::ReceiveHandshakeAck (or a few other handler states) and stop responding, leaving the client in a state where it perpetually waits for the next part of the handshake. This is because there is no timeout on connections during the handshake, leading to a Denial of Service scenario.

(Ignore the selected weakness - no standard "Denial of Service" weakness existed for some reason).

File reference: network-libp2p/src/discovery/handler.rs
Line: 477

Recommendation

Add a timeout on the discovery handler handshake that fails the handshake after a period of time.

Impact

A malicious peer could intentionally stall out victim peers
jsdanielh added a commit that referenced this issue May 9, 2024
@jsdanielh
network-libp2p: Add discovery state transition timeout
2bbdcba 
Add timeout for the state transition in the discovery handler such
that a peer don't hold us in a state indefinitely if it does't send
us back a message we expect.

This fixes #2458.
jsdanielh added a commit that referenced this issue May 9, 2024
@jsdanielh
network-libp2p: Add discovery state transition timeout
c122841 
Add timeout for the state transition in the discovery handler such
that a peer don't hold us in a state indefinitely if it doesn't send
us back a message we expect.

This fixes #2458.
@jsdanielh jsdanielh linked a pull request May 9, 2024 that will close this issue
Open
3 tasks
jsdanielh added a commit that referenced this issue May 9, 2024
@jsdanielh
network-libp2p: Add discovery state transition timeout
1cfe168 
Add timeout for the state transition in the discovery handler such
that a peer don't hold us in a state indefinitely if it doesn't send
us back a message we expect.

This fixes #2458.
@jsdanielh jsdanielh self-assigned this May 10, 2024
jsdanielh added a commit that referenced this issue May 10, 2024
@jsdanielh
network-libp2p: Add discovery state transition timeout
fd8f7aa 
Add timeout for the state transition in the discovery handler such
that a peer don't hold us in a state indefinitely if it doesn't send
us back a message we expect.

This fixes #2458.
jsdanielh added a commit that referenced this issue May 15, 2024
@jsdanielh
network-libp2p: Add discovery state transition timeout
17e84d6 
Add timeout for the state transition in the discovery handler such
that a peer don't hold us in a state indefinitely if it doesn't send
us back a message we expect.

This fixes #2458.
jsdanielh added a commit that referenced this issue May 15, 2024
@jsdanielh
network-libp2p: Add discovery state transition timeout
a49b106 
Add timeout for the state transition in the discovery handler such
that a peer don't hold us in a state indefinitely if it doesn't send
us back a message we expect.

This fixes #2458.
jsdanielh added a commit that referenced this issue May 16, 2024
@jsdanielh
network-libp2p: Add discovery state transition timeout
16d5ff9 
Add timeout for the state transition in the discovery handler such
that a peer don't hold us in a state indefinitely if it doesn't send
us back a message we expect.

This fixes #2458.
jsdanielh added a commit that referenced this issue May 17, 2024
@jsdanielh
network-libp2p: Add discovery state transition timeout
2b9c6d0 
Add timeout for the state transition in the discovery handler such
that a peer don't hold us in a state indefinitely if it doesn't send
us back a message we expect.

This fixes #2458.
@styppo styppo added this to the Nimiq PoS Mainnet milestone May 20, 2024
jsdanielh added a commit that referenced this issue May 20, 2024
@jsdanielh
network-libp2p: Add discovery state transition timeout
1bfe8cd 
Add timeout for the state transition in the discovery handler such
that a peer don't hold us in a state indefinitely if it doesn't send
us back a message we expect.

This fixes #2458.
jsdanielh added a commit that referenced this issue May 22, 2024
@jsdanielh
network-libp2p: Add discovery state transition timeout
34d0bcb 
Add timeout for the state transition in the discovery handler such
that a peer don't hold us in a state indefinitely if it doesn't send
us back a message we expect.

This fixes #2458.
jsdanielh added a commit that referenced this issue May 22, 2024
@jsdanielh
network-libp2p: Add discovery state transition timeout
87871e2 
Add timeout for the state transition in the discovery handler such
that a peer don't hold us in a state indefinitely if it doesn't send
us back a message we expect.

This fixes #2458.
jsdanielh added a commit that referenced this issue May 22, 2024
@jsdanielh
network-libp2p: Add discovery state transition timeout
af11bf4 
Add timeout for the state transition in the discovery handler such
that a peer don't hold us in a state indefinitely if it doesn't send
us back a message we expect.

This fixes #2458.
jsdanielh added a commit that referenced this issue May 27, 2024
@jsdanielh
network-libp2p: Add discovery state transition timeout
88323cb 
Add timeout for the state transition in the discovery handler such
that a peer don't hold us in a state indefinitely if it doesn't send
us back a message we expect.

This fixes #2458.
jsdanielh added a commit that referenced this issue May 27, 2024
@jsdanielh
network-libp2p: Add discovery state transition timeout
9d3a23c 
Add timeout for the state transition in the discovery handler such
that a peer don't hold us in a state indefinitely if it doesn't send
us back a message we expect.

This fixes #2458.
jsdanielh added a commit that referenced this issue May 30, 2024
@jsdanielh
network-libp2p: Add discovery state transition timeout
a920a01 
Add timeout for the state transition in the discovery handler such
that a peer don't hold us in a state indefinitely if it doesn't send
us back a message we expect.

This fixes #2458.
jsdanielh added a commit that referenced this issue May 30, 2024
@jsdanielh
network-libp2p: Add discovery state transition timeout
779b2a1 
Add timeout for the state transition in the discovery handler such
that a peer don't hold us in a state indefinitely if it doesn't send
us back a message we expect.

This fixes #2458.
jsdanielh added a commit that referenced this issue May 30, 2024
@jsdanielh
network-libp2p: Add discovery state transition timeout
a6bbf4a 
Add timeout for the state transition in the discovery handler such
that a peer don't hold us in a state indefinitely if it doesn't send
us back a message we expect.

This fixes #2458.
jsdanielh added a commit that referenced this issue May 30, 2024
@jsdanielh
network-libp2p: Add discovery state transition timeout
70cb187 
Add timeout for the state transition in the discovery handler such
that a peer don't hold us in a state indefinitely if it doesn't send
us back a message we expect.

This fixes #2458.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsdanielh jsdanielh

Labels
HackerOne
Projects
None yet
Milestone
Nimiq PoS Mainnet
Development

Successfully merging a pull request may close this issue.

network-libp2p: Add fixes and improvements to discovery protocol nimiq/core-rs-albatross
2 participants
@jsdanielh @styppo