Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename npm package name #2449

Closed
onmax opened this issue May 9, 2024 · 0 comments · Fixed by #2485
Closed

Rename npm package name #2449

onmax opened this issue May 9, 2024 · 0 comments · Fixed by #2485
Assignees
@sisou
Milestone
Nimiq PoS Mainnet

Comments

@onmax
Copy link
Member

onmax commented May 9, 2024 •
edited

See comment from @sisou:

I agree this has become confusing and bad DX.

So I see two ways forward:

  1. Continue using @nimiq/core-web for the builds targeted at browsers (bundler and web targets), but use the @nimiq/core package for the nodejs target (keeping both packages active).
  2. Change over to the @nimiq/core package and deprecate @nimiq/core-web. We shouldn't have to change any default export, as the NodeJS environment should still load the nodejs target by default with the export map (needs verification).

Alberto, Stefan and I agreed on 2: @nimiq/core package. Other opinions are welcome.

More context:
jsdanielh added a commit that referenced this issue May 20, 2024
@jsdanielh
web-client: Rename npm package
985f6db 
Rename `npm` package from `core-web` to `core` and use a better
versioning scheme: from `2.0.0-alpha.21.1` to `2.0.0-next.21.1`.

This closes #2449.
@jsdanielh jsdanielh mentioned this issue May 20, 2024
Merged
3 tasks
jsdanielh added a commit that referenced this issue May 20, 2024
@jsdanielh
web-client: Rename npm package
617a9e0 
Rename `npm` package from `core-web` to `core` and use a better
versioning scheme: from `2.0.0-alpha.21.1` to `2.0.0-next.21.1`.

This closes #2449.
jsdanielh added a commit that referenced this issue May 20, 2024
@jsdanielh
web-client: Rename npm package
f077aff 
Rename `npm` package from `core-web` to `core` and use a better
versioning scheme: from `2.0.0-alpha.21.1` to `2.0.0-next.21.1`.

This closes #2449.
@styppo styppo added this to the Nimiq PoS Mainnet milestone May 20, 2024
@onmax onmax mentioned this issue May 20, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sisou sisou

Labels
None yet
Projects
None yet
Milestone
Nimiq PoS Mainnet
Development

Successfully merging a pull request may close this issue.

web-client: Rename npm package nimiq/core-rs-albatross
3 participants
@sisou @styppo @onmax