WASM: add abstraction for tokio::spawn
#2442
Conversation
| @@ -23,7 +23,7 @@ workspace = true | |||
| async-trait = "0.1" | |||
| futures = { package = "futures-util", version = "0.3" } | |||
| futures-executor = { version = "0.3" } | |||
| instant = { version = "0.1", features = [ "wasm-bindgen" ] } | |||
| instant = { version = "0.1", features = ["wasm-bindgen"] } | |||
There was a problem hiding this comment.
I think we would want to introduce a feature called wasm_bindgen that enables this other feature such that it doesn't always get pulled. Something like:
[features]
wasm-bindgen = ["instant/wasm-bindgen"]
| .expect("Client initialization failed"); | ||
| let mut client = nimiq::client::Client::from_config(config) | ||
| .await | ||
| .expect("Client initialization failed"); | ||
| log::info!("Web client initialized"); | ||
|
|
||
| // Start consensus. |
There was a problem hiding this comment.
@styppo the web-client crate has a bunch of wasm_bindgen::spawn_locals. Those can get replaced with the new spawn abstraction too.
There was a problem hiding this comment.
In that case it is guaranteed for it to not be a tokio::spawn though as the web client will be compiled for the wasm target always. It could be done, but it would not add much I guess.
There was a problem hiding this comment.
That's true but for consistency across the codebase using the abstraction as much makes sense. For example if you want to alter the impl behind the abstraction maybe later in the far future.
styppo
force-pushed
the
styppo/spawn
branch
2 times, most recently
from
36e81ce
to
c1d996a
Compare
- Add a utility function `spawn` which calls `wasm_bindgen_futures::spawn_local` for WASM targets and `tokio::spawn` otherwise. - Remove `TaskExecutor`.
spawnwhich callswasm_bindgen_futures::spawn_localfor WASM targets andtokio::spawnotherwise.TaskExecutor.Closes #2434.