Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix better_errors gem version and move it to web variant #236

Closed
rafayet-monon opened this issue Oct 2, 2020 · 1 comment
Closed

Fix better_errors gem version and move it to web variant #236

rafayet-monon opened this issue Oct 2, 2020 · 1 comment

Comments

@rafayet-monon
Copy link
Contributor

rafayet-monon commented Oct 2, 2020

What Happened

The current better_errors gem version is 2.8.2 which got some broken things that can be faced while creating a project using this rails-template. There Is an open PR regarding this issue which isn't merged yet. The error given is -

image

A recent CI fail can also be found here - https://nimble.semaphoreci.com/jobs/9b9da4fc-4176-490b-aa4c-0586bc8d710c

How to Fix

In this scenario should we can downgrade and fix the better_errors version till a new release arrives.

Also, better_errors is only used in web variant applications only. Should we move this to the web_variant in this case?

@rafayet-monon
Copy link
Contributor Author

A recent better_errors version 2.8.3 was released on 3 Oct which implemented the fixes. Will open a different issue regarding better_errors being in web_variant. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant