Normalize enum value to ClassConstFetch #940
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruudk
force-pushed
the
enum-normalize
branch
3 times, most recently
from
7438d96
to
f302ccb
Compare
ruudk
commented
Aug 15, 2023
Comment on lines
+11
to
+15
| if (\PHP_VERSION_ID <= 80100) { | ||
| $this->markTestSkipped('Enums are supported since PHP 8.1'); | ||
| } | ||
|
|
||
| include __DIR__ . '/../code/Suit.php'; |
There was a problem hiding this comment.
@nikic Is this the correct way to handle this?
|
Hi, just encountered the problem described in #930. I can confirm the solution proposed here fixes the issue. What is the status of this PR, please? It has been pending for a while now |
|
@nikic could you have a look please 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #930