Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrettyPrinterAbstract refactoring #868

Open
WinterSilence opened this issue Aug 7, 2022 · 0 comments
Open

PrettyPrinterAbstract refactoring #868

WinterSilence opened this issue Aug 7, 2022 · 0 comments

Comments

@WinterSilence
Copy link
Contributor

WinterSilence commented Aug 7, 2022 •
edited

Current implementation have some problems:

  1. Can't customize EOL and left offset, by default printer use "\n" instead PHP_EOL or auto-detecting by first line
  2. Parent node/scope not passing to p*() methods and we can't customize results base on his scope/context.
  3. No flexible customization to p*() methods: need mechanics to call custom callbacks instead self methods to avoid duplicating code that can occurs at class extending.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WinterSilence