[DNumber] Add rawValue attribute to hold the original value #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-dnumber-parse
branch
from
133e020
to
d50a25b
Compare
|
This PR will help using native node properties, instead of token + attribute hacking: |
TomasVotruba
force-pushed
the
tv-dnumber-parse
branch
from
b4c647a
to
f030437
Compare
TomasVotruba
changed the title
TomasVotruba
commented
May 12, 2022
Comment on lines
+27
to
+37
| /** | ||
| * @param mixed[] $attributes | ||
| */ | ||
| public static function fromString(string $str, array $attributes = []): DNumber | ||
| { | ||
| $attributes['rawValue'] = $str; | ||
| $float = self::parse($str); | ||
|
|
||
| return new DNumber($float, $attributes); | ||
| } | ||
|
|
There was a problem hiding this comment.
This method should mirror the LNumber::fromString() https://github.com/nikic/PHP-Parser/pull/832/files#diff-dcef01e803010221926e1c1f1d388bd86cd219dc843253abf177cca48fb57ba1
We could add this to grammar itself, but it would require either custom method in AbstractParser or some grammar coding. That would be both harder to maintain and inconsistent with LNumber.
TomasVotruba
force-pushed
the
tv-dnumber-parse
branch
from
f030437
to
153fcb0
Compare
|
The value is now in Ready for review ✔️ |
|
👏 |
|
With this feature, tokens are now finally removed from @rectorphp 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirror to #832