We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The changes in 4.6.0 to the trailing comment newlines broke unterminated comment parsing errors. Here's a failing build.
A minimal repro case for the issue:
<?php require 'vendor/autoload.php'; use PhpParser\Error; use PhpParser\ParserFactory; $parser = (new ParserFactory)->create(ParserFactory::ONLY_PHP7); // this one works (fails?) as expected try { $parser->parse("<?php /* unterminated comment"); echo "boo :(\n"; } catch (Error $error) { echo "yay! {$error->getMessage()}\n"; } // this one parses as a valid comment try { $parser->parse("<?php /* unterminated comment\n"); echo "boo :(\n"; } catch (Error $error) { echo "yay! {$error->getMessage()}\n"; }
The text was updated successfully, but these errors were encountered:
739b4b4
Thanks for catching this!
Sorry, something went wrong.
Thank you for the quick fix!
No branches or pull requests
The changes in 4.6.0 to the trailing comment newlines broke unterminated comment parsing errors. Here's a failing build.
A minimal repro case for the issue:
The text was updated successfully, but these errors were encountered: