Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/4157 Abort test on waitUntilfailure when using it standalone with async/await #4165

Conversation

capGoblin
Copy link

@capGoblin capGoblin commented Apr 1, 2024

Fixes: #4157
Currently, when using the waitUntil command standalone with async/await, the test continues execution even after a timeout occurs. Here, I altered the condition inside shouldNodeRejectPromise to reject waitUntil's promise eventually aborting the test in case of an error(TimeoutError). And would love to hear any suggestions/opinions

  • Before marking your PR for review, please test and verify your changes by making appropriate modifications to any of the Nightwatch example tests (present in examples/tests directory of the project) and running them. ecosia.js and duckDuckGo.js are good examples to work with.
  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@garg3133
Copy link
Member

This was fixed in #4161 but thanks a lot for your efforts. You did manage to find the root cause of the issue and fix it, though the solution needed to be made more specific so that it only affect the waitUntil command, while also making it scalable to other commands.

We'll try to go through your other PRs as well in the coming days.

@garg3133 garg3133 closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abort test on waitUntil failure when using it standalone with async/await.
2 participants