Updates in lib/core/client.js

[Durgesh4993]

Description

I can suggest a few general improvements or alternatives based on common practices:

• Use ES6 Modules: Instead of require, use import and export statements for better module management and code organization.

• Async/Await: Utilize async and await for handling asynchronous operations, making the code cleaner and more readable.

• Class and Method Decomposition: Break down the large classes into smaller, more focused classes or functions, adhering to the single responsibility principle.

• Dependency Injection: Instead of directly instantiating dependencies within classes, consider injecting them as constructor parameters or using a dependency injection container for better testability and flexibility.

• Error Handling: Implement more robust error handling mechanisms, such as try-catch blocks, to gracefully handle errors and prevent crashes.

• Functional Programming: Utilize functional programming concepts and lodash functions for cleaner and more expressive code.

• Configuration Management: Separate configuration settings into a dedicated configuration file or object for better maintainability and flexibility.

Suggested solution

import { EventEmitter } from 'events';
import { Key, Browser } from 'selenium-webdriver';
import _merge from 'lodash/merge';
import HttpRequest from '../http/request.js';
import Settings from '../settings/settings.js';
import CommandQueue from './queue.js';
import Transport from '../transport';
import Element from '../element';
import ApiLoader from '../api';
import ElementGlobal from '../api/_loaders/element-global.js';
import Factory from '../transport/factory.js';
import { isAndroid, isIos, isSafari, isChrome } from '../utils/mobile';
import namespacedApi from '../core/namespaced-api.js';
import cdp from '../transport/selenium-webdriver/cdp.js';

import { LocateStrategy, Locator } from '../element';
import { Logger, isUndefined, isDefined, isObject, isFunction } from '../utils';

class NightwatchAPI {
  constructor(sessionId, settings) {
    this.capabilities = {};
    this.desiredCapabilities = settings.capabilities || settings.desiredCapabilities;
    this.sessionId = sessionId;
    this.options = settings;
    this.globals = settings.globals;
  }

  // Other methods...
}

class NightwatchClient extends EventEmitter {
  static create(settings, argv) {
    const client = new NightwatchClient(settings, argv);
    client.setupBrowserGlobalAPI();
    return client;
  }

  constructor(userSettings = {}, argv = {}) {
    super();
    this.settings = Settings.fromClient(userSettings, argv);
    // Other initializations...
  }

  setupBrowserGlobalAPI() {
    if (!this.settings.disable_global_apis) {
      global.browser = this.api;
    }

    // Clear namespaced API...
  }

  // Other methods...
}

export default NightwatchClient;

Additional Information

Can i work on this

[Sunilverma99]

can i work on this

[gravityvi]

@Durgesh4993 I would recommend you to spend some time with the Project. The items suggested in your issue might have negative impact on repository (like including all lodash dependencies increases the size of the project). Pick some existing good first issues in from the issue list and try solving them.