Add aliases for find() and findAll() command in new Element API

[garg3133]

Description of the issue

The following APIs should work in the new Element API:

Commands to find a single element:

• browser.element.find('selector')
• browser.element.get('selector')
• browser.element.findElement('selector')
• browser.element('selector').find('child-selector')
• browser.element('selector').get('child-selector')
• browser.element('selector').findElement('child-selector')

Commands to find multiple elements:

• browser.element.findAll('selector')
• browser.element.getAll('selector')
• browser.element.findElements('selector')
• browser.element('selector').findAll('child-selector')
• browser.element('selector').getAll('child-selector')
• browser.element('selector').findElements('child-selector')

The main commands above are find() and findAll() (for which corresponding files are present in lib/api/web-element/commands directory) and all others are the aliases of these two commands.

Some of the aliases above already exist while others don't, so we need to make sure that all of the above commands work in both JS and TS (with correct typings).

TODO

• Add missing aliases
• Add tests for the added aliases
• Add missing types and tests for the added types

[garg3133]

The two sections of commands above (find and findAll) can be taken up separately by different contributors.

[abhishekchauhan15]

Hey, @garg3133 can take up this issue?

[garg3133]

Hi, please go through GSoC Contributor Guidance for Nightwatch. It contains details on how the issues will be assigned.

[subhajit20]

Hey @garg3133 I have a question that let us suppose the find command - it is an aliases of findall command right and get is aliases of getall and vice versa.
right ?

[garg3133]

@subhajit20 No, find and findAll are separate commands.

[subhajit20]

@subhajit20 No, find and findAll are separate commands.

Then find and findElement are almost the same. Are they can be aliases for each other?

[garg3133]

@subhajit20 Yes, all the commands that are written together in the issue description are supposed to be aliases of each other.

[subhajit20]

@subhajit20 Yes, all the commands that are written together in the issue description are supposed to be aliases of each other.

Okay Got it.
Thanks!!

[subhajit20]

Hey @garg3133 can you check my PR once and let me know if any further changes are needed?

[its-kunal]

Hey @garg3133, Please review my pull request - #4067 .

[srajan07]

can you assign me this issue?

[Chamara00]

@garg3133 can you assign this to me?

[its-kunal]

Hey @garg3133, Please review my pull request - #4067

[Jai0401]

@garg3133 can you please review my PR?

[AritraLeo]

Hi @garg3133 just curious if this issue is still open because there are so many PRs open so far. If not I am willing to work on this one!

[garg3133]

@AritraLeo Yes, this issue is still open and we still don't have a PR that solves this issue completely, although #4067 is quite close but there are still a few things missing from there.

[AritraLeo]

@AritraLeo Yes, this issue is still open and we still don't have a PR that solves this issue completely, although #4067 is quite close but there are still a few things missing from there.

Ohk I'll start working on it and come up with a PR soon !

[AritraLeo]

@garg3133 so far I have added declarations for get and getAll() and findElement and findElements in types/web-element.d.ts also added alias tag to find and findAll command files.
but to run the test for checking in ecosia file I had written -

it('Test get() alias', function(browser) {
   browser
     .find('input[type=search]')
     .assert.visible('input[type=search]');
 });

this simple test but it seems even find is not working properly. Please correct me so that I can run the tests successfully!

[garg3133]

@AritraLeo .find() is not directly available on browser. It's either browser.element('selector').find('child selector') or browser.element.find('selector') as mentioned in the issue description.

[AritraLeo]

@AritraLeo .find() is not directly available on browser. It's either browser.element('selector').find('child selector') or browser.element.find('selector') as mentioned in the issue description.

Ohk, I see my bad apologies for the oversight.

[AritraLeo]

@garg3133 Please have a look at my PR !

[Ankuristic]

could i start working on this issue or this issue is already closed

[Visbhavesh]

hey assign these issue to me and I will resolve these

[garg3133]

In order to discourage duplicate PRs on an issue, assigning this issue to @AritraLeo since their PR #4130 is under active development and also very close to the solution.

Moving forward, we will only be reviewing PRs from the person to whom the issue is assigned.

[Ashu463]

Hey @AritraLeo could you pls share current status of this issue ? because upon following your and @garg3133 conversation it's too much clear in my head.
so that I could help to solve this issue soon.

[garg3133]

@Ashu463 This issue is almost solved in #4130, I just need to do a final review of the PR.

[Ashu463]

Yeah! I think that it is solved but I just asked if any task remaining then I could help.
Btw Thanks for informing.

[garg3133]

Fixed in #4130.