Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing isEnabled command to new Element API #4032

Closed
4 tasks
garg3133 opened this issue Feb 22, 2024 · 3 comments
Closed
4 tasks

Add missing isEnabled command to new Element API #4032

garg3133 opened this issue Feb 22, 2024 · 3 comments
Assignees

Comments

@garg3133
Copy link
Member

garg3133 commented Feb 22, 2024

Description of the bug/issue

The isEnabled command is currently missing from the new Element API. To support this command, a new file named isEnabled.js needs to be added inside lib/api/web-element/commands directory, whose content should be similar to the get* command files present in the same directory.

The argument passed to this.runQueuedCommandScoped in these files is the name of the corresponding method to be called from the lib/transport/selenium-webdriver/method-mappings.js file.

Steps to reproduce

Go to any test file and try to add const result = await browser.element('<selector>').isEnabled() and then run the test. This would result in error, while if you replace isEnabled() with getText(), it should work fine.

TODO

  • Add missing command
  • Fix JSDoc of the command
  • Add tests for the new command
  • Add types for the new command
@subhajit20
Copy link
Contributor

hey @garg3133 , is there any changes needed ? Let me know.
And please assign me the issue

@starvader13
Copy link

Hey @garg3133 , I can take this issue and fix it up. Can you assign this to me?

@garg3133
Copy link
Member Author

Completed in #4041.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants