Issue/2618 element timeout #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove redundant assignment (#2635)
beatfactor
reviewed
Apr 14, 2021
| @@ -80,6 +80,10 @@ class AssertionInstance { | |||
| return this.__negate; | |||
| } | |||
|
|
|||
| get retryAssertionTimeout() { | |||
| return Array.isArray(this.__args) && this.__args[0].timeout; | |||
There was a problem hiding this comment.
there's a getter for this.args, so you can rewrite this as: return this.args[0]
beatfactor
reviewed
Apr 14, 2021
| }); | ||
| }); | ||
|
|
||
| it.only('visible assertion passed with selector object and timeout', function () { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.
features/my-new-featureorissue/123-my-bugfix);