[improvement] setting locate strategy page objects #2616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.
Create a new branch from master (e.g.
features/my-new-feature
orissue/123-my-bugfix
);If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
Proposed this in discussion section.
Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
I believe it's a small change.
If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
Don't think so.
Do not include changes that are not related to the issue at hand;
Check.
Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
Might be room for improvement.
Always add unit tests - PRs without tests are most of the times ignored.
Check.