Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement] setting locate strategy page objects #2616

Conversation

FrederikCampagne
Copy link

@FrederikCampagne FrederikCampagne commented Mar 18, 2021

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);

  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
    Proposed this in discussion section.

  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
    I believe it's a small change.

  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
    Don't think so.

  • Do not include changes that are not related to the issue at hand;
    Check.

  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
    Might be room for improvement.

  • Always add unit tests - PRs without tests are most of the times ignored.
    Check.

@FrederikCampagne FrederikCampagne force-pushed the fix-setting-locate-strategy-page-objects branch from e34c0a6 to 8270acf Compare March 18, 2021 12:06
@FrederikCampagne
Copy link
Author

Perhaps LocateStrategy.getDefault() can be removed?

@beatfactor
Copy link
Member

beatfactor commented Mar 18, 2021

Perhaps LocateStrategy.getDefault() can be removed?

You mean from the Element class? If it's not needed, sure.

@beatfactor
Copy link
Member

Perhaps LocateStrategy.getDefault() can be removed?

You mean from the Element class? If it's not needed, sure.

It is needed for situations where there's no parent and no strategy given.

@beatfactor beatfactor merged commit 5a9727f into nightwatchjs:main Mar 19, 2021
@beatfactor beatfactor linked an issue Mar 19, 2021 that may be closed by this pull request
@FrederikCampagne FrederikCampagne deleted the fix-setting-locate-strategy-page-objects branch March 19, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use test setting "use_xpath" as default for page objects
2 participants