Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W3C WebDriver spec links not working for a lot of pages #293

Open
1 of 2 tasks
garg3133 opened this issue Mar 26, 2024 · 4 comments
Open
1 of 2 tasks

W3C WebDriver spec links not working for a lot of pages #293

garg3133 opened this issue Mar 26, 2024 · 4 comments

Comments

@garg3133
Copy link
Member

garg3133 commented Mar 26, 2024

There are a lot of pages in the API docs which have an invalid link in the "W3C WebDriver spec" section. See this page for one such example.

  • We need to fix all such invalid links in the API docs. This can ideally be fixed by adding the WebDriver spec doc link as the prefix if the link does not start with http. This change only needs to be made at a single place in this repo where we convert the JSDoc tags to HTML.
  • Additionally, all the links related to W3C should be placed in the @link tag in JSDoc throughout the Nightwatch APIs (present in nightwatchjs/nightwatch repo), and all other links should be put in the @see tag.
@ParmarKrishna
Copy link
Contributor

I understood the issue here, and I am working on it.

ParmarKrishna added a commit to ParmarKrishna/nightwatch-docs that referenced this issue Mar 27, 2024
ParmarKrishna added a commit to ParmarKrishna/nightwatch-docs that referenced this issue Mar 28, 2024
@ParmarKrishna
Copy link
Contributor

ParmarKrishna commented Apr 2, 2024

all the links related to W3C should be placed in the @link tag in JSDoc throughout the Nightwatch APIs (present in nightwatchjs/nightwatch repo), and all other links should be put in the @see tag.

Regarding this, there are two versions of @link tag found in the files. For example, lib/api/client-commands/document/source.js has entire link (such as, @link https://www.w3.org/TR/webdriver#getting-page-source) in the tag, where as other files such as, lib/api/client-commands/document/executeAsyncScript.js has only /#execute-async-script in the tag.

Hence, should link tag contain only #references-page or entire link as shown above?
Additionally, the URL is also incorrect.

@garg3133
Copy link
Member Author

garg3133 commented Apr 2, 2024

The @link tag can contain links in /#execute-async-script format only, no need to specify complete URLs.

There are also some pages where the @link tag is incorrect (ex. the link present in element.clickAndHold page doesn't lead to anywhere), we'd need to fix those as well (or remove them if there's no such section and instead add a selenium doc reference).

Also, if there are some non-webdriver spec related links present in the @link tag, we would need to move them to @see tag. Similarly, if there are some webdriver spec related links present in @see tag, we'd move them to @link tag.

@ParmarKrishna
Copy link
Contributor

okay. understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants