Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add component tests #39

Open
vaibhavsingh97 opened this issue Feb 26, 2024 · 14 comments · May be fixed by #62, #61 or #59
Open

Add component tests #39

vaibhavsingh97 opened this issue Feb 26, 2024 · 14 comments · May be fixed by #62, #61 or #59
Labels
good first issue Good for newcomers

Comments

@vaibhavsingh97
Copy link
Member

vaibhavsingh97 commented Feb 26, 2024 •
edited

Description

Currently, only Header and Footer have component tests. However, these tests are naive. We need to update them and create new tests for all other components.

TODO

Add tests for these component: https://github.com/nightwatchjs/html-reporter/tree/main/src/components

What do sample tests look like?

Let's see the Header component
localhost_5173_

Here, we can assert the presence and visibility of the Nightwatch.js logo. We can also verify that the "Test Report", date, and time are being rendered.

Reference

https://nightwatchjs.org/guide/component-testing/write-jsx-react-tests.html
@vaibhavsingh97 vaibhavsingh97 added the good first issue Good for newcomers label Feb 26, 2024
@adityak714
Copy link

Hello, I would like to take on this issue, if possible.

@vaibhavsingh97
Copy link
Member Author

Sure, since multiple people can work on this master issue, it would be awesome if you could let us know which component you would like to add tests for by leaving a comment.

@vaibhavsingh97 vaibhavsingh97 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 26, 2024
@adityak714
Copy link

I could start with the FilterDropdown and Search components.

@0-sayed
Copy link

0-sayed commented Feb 28, 2024

Hello, I would like to update Header and Footer, and create tests for tooltip

@adityak714 adityak714 mentioned this issue Mar 2, 2024
Open
@subhajit20 subhajit20 mentioned this issue Mar 3, 2024
Merged
@piyushmishra1416 piyushmishra1416 mentioned this issue Mar 4, 2024
Open
@subhajit20 subhajit20 mentioned this issue Mar 6, 2024
Open
@Temidayo32
Copy link

@vaibhavsingh97 I will work on LogView

@Temidayo32 Temidayo32 mentioned this issue Mar 8, 2024
Open
@aliamerj
Copy link

I will take ChipWithIcon

@piyushmishra1416
Copy link

piyushmishra1416 commented Mar 12, 2024 •
edited

I have opened a PR for AlertBanner component.

@subhajit20 subhajit20 mentioned this issue Mar 12, 2024
Open
11 tasks
This was referenced Mar 12, 2024
Closed
Closed
@JeremiahHerring JeremiahHerring mentioned this issue Mar 22, 2024
Open
@JeremiahHerring
Copy link

I made a PR #56 for the FilePathView component

@Ankuristic
Copy link

is AlertBanner Component is still tested

@Ankuristic
Copy link

Hi @vaibhavsingh97 i am doing the FilterDropdown component test

@JeremiahHerring
Copy link

Created Draft PR #58 for ErrorFallBack Component, still need to add more test functionalities but it's a good start to the test file

This was referenced Mar 26, 2024
Open
Open
Open
@bboinnovate20
Copy link

bboinnovate20 commented Mar 27, 2024 •
edited

Added test Timer Component #63

#63 (comment) fix for #39

@bboinnovate20 bboinnovate20 mentioned this issue Mar 27, 2024
Closed
@SohaibMagrabi
Copy link

added test search component

@SohaibMagrabi
Copy link

added test for separator and screenshot components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
10 participants
@vaibhavsingh97 @bboinnovate20 @Ankuristic @aliamerj @Temidayo32 @adityak714 @piyushmishra1416 @JeremiahHerring @SohaibMagrabi @0-sayed