restore Maven 3.0.5 prerequisite #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
=========================================
Coverage 77.91% 77.91%
Complexity 187 187
=========================================
Files 27 27
Lines 661 661
Branches 77 77
=========================================
Hits 515 515
Misses 113 113
Partials 33 33 Continue to review full report at Codecov.
|
hboutemy
force-pushed
the
maven-version
branch
2 times, most recently
from
2529479
to
8ded8f1
Compare
|
notice that failures on Maven 3.0.5 and 3.1.1 are not really plugin compatibility issues but default use of HTTP that is nowadays not supported any more: HTTPS is required |
This was referenced Jul 5, 2021
michael-o
suggested changes
Jul 5, 2021
| @@ -54,6 +54,8 @@ jobs: | |||
| shell: bash | |||
| run: | | |||
| unset M2_HOME | |||
| mkdir -p ~/.m2 | |||
| echo "<settings><mirrors><mirror><mirrorOf>central</mirrorOf><name>central</name><url>https://repo.maven.apache.org/maven2/</url></mirror></mirrors></settings>" > ~/.m2/settings.xml # reqiored by Maven < 3.2.3 | |||
There was a problem hiding this comment.
At the end is a typo: reqiored
There was a problem hiding this comment.
Also, integration tests does not seem to use this conf, see test failures
nicoulaj
added a commit
that referenced
this pull request
Jul 5, 2021
nicoulaj
added a commit
that referenced
this pull request
Jul 5, 2021
nicoulaj
added a commit
that referenced
this pull request
Jul 5, 2021
nicoulaj
added a commit
that referenced
this pull request
Jul 5, 2021
nicoulaj
added a commit
that referenced
this pull request
Jul 5, 2021
…=> drop support for Maven 3.0.x
nicoulaj
added a commit
that referenced
this pull request
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tester locally on my Linux box, everything seems to work, why reduce users choice?