From 64d7bf4838df85e7a7814cf4b034edad8ae5b07c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=B2=20Ribaudo?= Date: Tue, 5 Nov 2019 14:35:40 +0100 Subject: [PATCH] Revert "throw a TypeError if identifier validation fails (#10621)" This reverts commit c7d8b8a37752f42163128cf4d5e8b54c2637cec4. --- packages/babel-types/src/definitions/core.js | 6 +++--- packages/babel-types/src/index.js | 1 - packages/babel-types/src/validators/isIdentifierName.js | 9 --------- 3 files changed, 3 insertions(+), 13 deletions(-) delete mode 100644 packages/babel-types/src/validators/isIdentifierName.js diff --git a/packages/babel-types/src/definitions/core.js b/packages/babel-types/src/definitions/core.js index 2b7802096cd9..09c41c9119a9 100644 --- a/packages/babel-types/src/definitions/core.js +++ b/packages/babel-types/src/definitions/core.js @@ -1,5 +1,5 @@ // @flow -import isIdentifierName from "../validators/isIdentifierName"; +import isValidIdentifier from "../validators/isValidIdentifier"; import { BINARY_OPERATORS, @@ -406,8 +406,8 @@ defineType("Identifier", { ...patternLikeCommon, name: { validate: chain(function(node, key, val) { - if (!isIdentifierName(val)) { - throw new TypeError(`"${val}" is not a valid identifer name`); + if (!isValidIdentifier(val)) { + // throw new TypeError(`"${val}" is not a valid identifer name`); } }, assertValueType("string")), }, diff --git a/packages/babel-types/src/index.js b/packages/babel-types/src/index.js index a34588c85c06..d3311dfc9f2f 100644 --- a/packages/babel-types/src/index.js +++ b/packages/babel-types/src/index.js @@ -109,7 +109,6 @@ export { default as isValidES3Identifier, } from "./validators/isValidES3Identifier"; export { default as isValidIdentifier } from "./validators/isValidIdentifier"; -export { default as isIdentifierName } from "./validators/isIdentifierName"; export { default as isVar } from "./validators/isVar"; export { default as matchesPattern } from "./validators/matchesPattern"; export { default as validate } from "./validators/validate"; diff --git a/packages/babel-types/src/validators/isIdentifierName.js b/packages/babel-types/src/validators/isIdentifierName.js deleted file mode 100644 index 9cae809217cf..000000000000 --- a/packages/babel-types/src/validators/isIdentifierName.js +++ /dev/null @@ -1,9 +0,0 @@ -// @flow -import esutils from "esutils"; - -/** - * Check if the input `name` is a valid identifier name. - */ -export default function isIdentifierName(name: string): boolean { - return esutils.keyword.isIdentifierNameES6(name); -}