Renamed @types folder to types #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickytonline
added
the
merge by any core
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nickytonline/web3-starter/8e5dcST3e4BwUCVN9FuNog5grkUi |
nickytonline
commented
Dec 29, 2021
| @@ -17,7 +17,8 @@ | |||
| "baseUrl": ".", | |||
| "paths": { | |||
| "@components": ["components/index"], | |||
| "@components/*": ["components/*"] | |||
| "@components/*": ["components/*"], | |||
| "types/*": ["types/*"] | |||
There was a problem hiding this comment.
Added TypeScript alias which also translates to a webpack alias since this is a NEXT.js project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This wasn't a bug (at least right now) for the starter project itself, but projects that used it as a template had an issue when importing from the
@typesfolder in the project.Related Tickets & Documents
Closes #36
QA Instructions, Screenshots, Recordings
N/A
UI accessibility concerns?
N/A
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?