Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Josh W. Comeau's Custom CSS Reset #35

Closed
wants to merge 1 commit into from

Conversation

nickytonline
Copy link
Owner

@nickytonline nickytonline commented Dec 29, 2021

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Moved the CSS part of the codebase to Josh's CSS reset.

Related Tickets & Documents

Closes #34

QA Instructions, Screenshots, Recordings

N/A aside from the deploy preview should look like this.

CleanShot 2021-12-28 at 23 50 09

UI accessibility concerns?

N/A

Added/updated tests?

  • Yes
  • No, and this is why: CSS changes only.
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Someone rolling paint onto a white wall

@nickytonline nickytonline added the merge by any core This tag is a signal that you are okay with any core team member merging your code for you. label Dec 29, 2021
@vercel
Copy link

vercel bot commented Dec 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nickytonline/web3-starter/FWbPNzGQGBybYjHqJNpmdPPNyMFM
✅ Preview: https://web3-starter-git-add-josh-w-comeau-css-reset-nickytonline.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge by any core This tag is a signal that you are okay with any core team member merging your code for you.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change CSS Reset to Josh W. Comeau's CSS Reset
1 participant