Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme UI <ThemeProvider /> does not work with Storybook #10

Closed
nickytonline opened this issue Oct 23, 2021 · 0 comments · Fixed by #19
Closed

Theme UI <ThemeProvider /> does not work with Storybook #10

nickytonline opened this issue Oct 23, 2021 · 0 comments · Fixed by #19
Assignees
@nickytonline
Labels
bug Something isn't working frontend infrastructure Anything related to frontend infrastructure.

Comments

@nickytonline
Copy link
Owner

nickytonline commented Oct 23, 2021 •
edited

Describe the bug

The Theme UI <ThemeProvider /> currently will not work with Storybook due to emotion dependency conflicts.

To Reproduce

We're not using the Theme UI <ThemeProvider /> in Storybook yet, but as mentioned above in the description, it's a known issue.

Expected behavior

The fix mentioned in system-ui/theme-ui#1530 (comment) works. I've implemented it in nickytonline/picture-portal@daddb14

Screenshots

N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
N/a
@nickytonline nickytonline added bug Something isn't working frontend infrastructure Anything related to frontend infrastructure. labels Oct 23, 2021
@teezzan teezzan mentioned this issue Oct 24, 2021
Merged
8 tasks
@nickytonline nickytonline self-assigned this Oct 28, 2021
@nickytonline nickytonline mentioned this issue Oct 28, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickytonline nickytonline

Labels
bug Something isn't working frontend infrastructure Anything related to frontend infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed Theme UI usage in Storybook nickytonline/web3-starter
1 participant
@nickytonline