If COVERALLS_SERVICE_NUMBER is set, set service_number from it.

[midgleyc]

Coveralls allows to set separately a service_number and job_id, but only the job_id was currently being set. This adds the option to use an environment variable to set a different service_number if desired.

I've also removed the duplicate service_pull_request set on the json.

[coveralls]

Coverage decreased (-0.3%) to 95.714% when pulling 609eeae on midgleyc:service_number into cc67125 on nickmerwin:master.

[coveralls]

Coverage decreased (-0.3%) to 95.714% when pulling 609eeae on midgleyc:service_number into cc67125 on nickmerwin:master.

[coveralls]

Coverage decreased (-0.3%) to 97.238% when pulling a7a73d0 on midgleyc:service_number into 2ea7be3 on nickmerwin:master.

[phated]

This should either use service_job_number or change those references to service_number because that option isn't being serialized currently.

Also, I'd love to see this patch landed.

[midgleyc]

Wouldn't it be better to serialize job number, if it can be specified using a separate environment variable?

Admittedly, I worked on this so long ago I don't recall how the service works any more.

[nickmerwin]

Hi @midgleyc could you supply an example setup on a CI where the explicit setting of that environment variable is necessary?

[midgleyc]

If I recall correctly, it was an Azure DevOps release pipeline.

[joscha]

can we get this one in, please?

[nickmerwin]

Hi @midgleyc would you be up for resolving the conflicts when you get a chance, please?

[midgleyc]

Sure, I think I've resolved it.

Bit of a blast from the past here, thanks for looking at it!

[nickmerwin]

Thank you @midgleyc! Releasing now.