Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to make testing easier #90

Merged
merged 8 commits into from Aug 6, 2022
Merged

Refactor to make testing easier #90

merged 8 commits into from Aug 6, 2022

Conversation

nick-fields
Copy link
Owner

@nick-fields nick-fields commented Aug 6, 2022

This PR mostly just extracts the various parts of index.ts out into separate files to make testing easier with no change to functionality. It also further splits up the existing "integration" workflow tests.

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2022

Codecov Report

Merging #90 (b3fd951) into master (616fa81) will increase coverage by 1.22%.
The diff coverage is 2.32%.

@@            Coverage Diff            @@
##           master     #90      +/-   ##
=========================================
+ Coverage    1.38%   2.61%   +1.22%     
=========================================
  Files           2       3       +1     
  Lines         144     153       +9     
  Branches       48      50       +2     
=========================================
+ Hits            2       4       +2     
- Misses        131     137       +6     
- Partials       11      12       +1     

@nick-fields nick-fields marked this pull request as ready for review August 6, 2022 03:17
@nick-fields nick-fields merged commit b4fa575 into master Aug 6, 2022
@nick-fields nick-fields deleted the nrf/more-tests branch August 6, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants