Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error icon is incorrectly spaced in nimble-text-field #2090

Open
mollykreis opened this issue May 9, 2024 · 1 comment
Open

Error icon is incorrectly spaced in nimble-text-field #2090

mollykreis opened this issue May 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@mollykreis
Copy link
Contributor

馃悰 Bug Report

In the nimble-text-field, the error "!" icon should be 8px from the edge of the component. However, it is currently 8px from the border, which makes it 9px from the edge of the component.

We should evaluate whether this is the case with other components as well.

馃捇 Repro or Code Sample

馃 Expected Behavior

The error icon in components should be 8px from the edge of the component, not 8px from the border of the component.

馃槸 Current Behavior

The error icon is 8px from the border of the component.

馃拋 Possible Solution

馃敠 Context

馃實 Your Environment

  • OS & Device: [e.g. MacOS, iOS, Windows, Linux] on [iPhone 7, PC]
  • Browser [e.g. Microsoft Edge, Google Chrome, Apple Safari, Mozilla FireFox]
  • Version [e.g. 1.8.0]
@mollykreis mollykreis added bug Something isn't working triage New issue that needs to be reviewed labels May 9, 2024
@m-akinc m-akinc removed the triage New issue that needs to be reviewed label May 14, 2024
@mollykreis
Copy link
Contributor Author

When this is fixed, we should remove the workaround added in this azdo PR to make the checkbox error icon align with the textfield error icon. Specifically, an extra 1px of padding was added to the right of the checkbox's error icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants