Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Node polyfill needed for markdown-it / rich text components #1700

Open
jattasNI opened this issue Dec 4, 2023 · 0 comments
Open

Remove Node polyfill needed for markdown-it / rich text components #1700

jattasNI opened this issue Dec 4, 2023 · 0 comments

Comments

@jattasNI
Copy link
Contributor

jattasNI commented Dec 4, 2023

馃Ч Tech Debt

In #1335 we added a Node polyfill to our Rollup configuration because markdown-it relied on Node's punycode package but Nimble runs in the browser environment, not Node.

Since then, Node deprecated punycode and markdown-it added a dependency on an npm package that provides that support
markdown-it/markdown-it#967

This should allow us to remove the polyfill once we uptake that version of markdown-it and confirm that everything still works.
https://github.com/ni/nimble/blob/5181411fa3c370713b581c4640babd6b5b55bc6b/packages/nimble-components/rollup.config.js#L7C8-L7C21

@jattasNI jattasNI added tech debt triage New issue that needs to be reviewed labels Dec 4, 2023
@m-akinc m-akinc added tiny馃悳 and removed triage New issue that needs to be reviewed labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants