Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reified support for refEq like other matchers #329

Merged
merged 1 commit into from Jun 19, 2019
Merged

Add reified support for refEq like other matchers #329

merged 1 commit into from Jun 19, 2019

Conversation

pablisco
Copy link
Contributor

This takes care of #328

Follow the same pattern as with other matchers using reified generics to generate an instance to avoid having a warning or failure when using !!

jimmyoak
jimmyoak approved these changes Apr 24, 2019
View reviewed changes
Copy link

@jimmyoak jimmyoak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need this fix 👍

xejarque
xejarque approved these changes Apr 24, 2019
View reviewed changes
Copy link

@xejarque xejarque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same problem and doing these changes works ok.

@pablisco
Copy link
Contributor Author

@nhaarman
Any thoughts on this? It's been 4 months...

@nhaarman
Copy link
Collaborator

Oops! I'll have a look at it soon.

@nhaarman nhaarman merged commit ffaddbb into mockito:2.x Jun 19, 2019
@nhaarman
Copy link
Collaborator

Thanks! Expect this in 2.2.0.

@nhaarman nhaarman mentioned this pull request Jun 19, 2019
Closed
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xejarque xejarque xejarque approved these changes

@jimmyoak jimmyoak jimmyoak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pablisco @nhaarman @xejarque @jimmyoak