Upgrade Gateway API to v1.1.0 #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1975 +/- ##
==========================================
+ Coverage 86.98% 87.03% +0.04%
==========================================
Files 89 89
Lines 6091 6091
Branches 50 50
==========================================
+ Hits 5298 5301 +3
+ Misses 741 737 -4
- Partials 52 53 +1 ☔ View full report in Codecov by Sentry. |
sjberman
reviewed
May 15, 2024
ciarams87
force-pushed
the
feat/upgrade-gw-api
branch
2 times, most recently
from
d76f843
to
b802280
Compare
ciarams87
force-pushed
the
feat/upgrade-gw-api
branch
2 times, most recently
from
8a798da
to
de0df2f
Compare
sjberman
approved these changes
May 16, 2024
ciarams87
force-pushed
the
feat/upgrade-gw-api
branch
from
de0df2f
to
7839f55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: We don't support the latest version of the Gateway API (v1.1.0)
Solution: Upgrade to the latest version. As part of this upgrade, we must/ can:
PolicyTargetReferencehas been removed, so useLocalPolicyTargetReferencefor the target refs in our new policies (can optionally useNamespacedPolicyTargetReferenceinstead, but we already have the requirement of the targets being in the same namespace as the policies)Testing: Ran the full conformance test suite, including the GRPCRoute tests. Locally tested the BackendTLSPolicy workflow following the guide.
Closes #1970
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.