Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors on sortable directive render with angular-13 #4

Closed
RobinKamps opened this issue Feb 15, 2022 · 3 comments
Closed

errors on sortable directive render with angular-13 #4

RobinKamps opened this issue Feb 15, 2022 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@RobinKamps
Copy link
Contributor

within angular 13 an error is raised for the nested droplist context on simple-kanban.

ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value: 'null'. Current value: 'false'.. Find more at https://angular.io/errors/NG0100
    at throwErrorIfNoChangesMode (errors.ts:63:9)
    at bindingUpdated (bindings.ts:72:12)
    at ɵɵproperty (property.ts:49:1)
    at KanbanListComponent_ng_template_6_Template (kanban-list.component.html:38:49)

even worse, if you drag one item like crazy between the lists often there is another error thrown:

Error in /turbo_modules/@react-dnd/invariant@2.0.0/dist/invariant.cjs.development.js (31:15)
Expected targetIds to be registered.

can you please check, if the example works for you with ng-13?

https://stackblitz.com/edit/github-wfbywn

@nzbin nzbin added the help wanted Extra attention is needed label Feb 19, 2022
@nzbin
Copy link
Contributor

nzbin commented Feb 19, 2022

For the first error, you can resolve it with OnPush strategy. I have updated your online demo

For the second error, I'm also not sure. Maybe you can check the react-dnd/react-dnd#763

@nzbin
Copy link
Contributor

nzbin commented Feb 19, 2022

I found it works very well with angular 12, maybe it's not compatible with angular 13. I will update it to angular 13 in a few days.

@RobinKamps
Copy link
Contributor Author

Thank you very much - OnPush does resolve the first part of the issue.
Unfortunatly the second part Expected targetIds to be registered is indeed related to nested react-dnd drop targets (and not directly ng-dnd related).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants