fix(datepicker): config not applied #4698
Open
+58
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the proposed fix for #4697 will not resolve the issue when
NgbDatepicker.navigateTo()
is called manually, only when it is called by setting the[startDate]
input. It seems reasonable to expect users not to call functions on components before they're initialized, so I believe this fix to be sufficient. That said, I'm more than happy to hear any feedback.Fixes #4697
Fixes #3848