Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log failed attempts #165

Open
jknockaert opened this issue Apr 7, 2017 · 2 comments
Open

log failed attempts #165

jknockaert opened this issue Apr 7, 2017 · 2 comments

Comments

@jknockaert
Copy link

I suggest that the app logs failed attempts much like the nextcloud core logs failed logins. That would allow to handle these security issues with external tools like fail2ban.

@ChristophWurst
Copy link
Member

Yeah that would make sense. Since that also makes sense for the other 2FA providers, I suggest to reopen this enhancement ticket in the server repo. Please mention me there and cross-reference this ticket.

Implementing the logging should be easy. Let me know if you'd like to help with this enhancement and I can point you to the effected files. This would be a great starting point for a contribution to the Nextcloud project 😉

On a side note: we do show failed 2FA attempts in the activity stream of the activity app on Nextcloud 12 and newer :-) ref #96

@ChristophWurst
Copy link
Member

(I'll leave this ticket open until we have the proper replacement in the server repo. This one can be closed then)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants