Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link preview and link bubble broken in public shares (and with reference_opengraph = false) #5520

Open
mejo- opened this issue Mar 18, 2024 · 1 comment
Labels
29 feedback bug Something isn't working

Comments

@mejo-
Copy link
Member

mejo- commented Mar 18, 2024

Describe the bug
In public shares we currently don't load previews (or other reference widgets). Same if reference_opengraph is disabled in server configuration. This leads to several issues:

  • Links that are configured to be displayed as previews don't get displayed at all
  • Links to other pages in the same collective don't get rerouted but instead get opened in a new tab

To Reproduce
Steps to reproduce the behavior:

  • Open a public share of a text file with links configured as link previews

Expected behavior

Some thoughts:

  • I wonder whether we should limit the effect of disabling reference_opengraph to disable previews of external pages and still load references to other objects from the same Nextcloud instance.
  • In public shares (or with reference_opengraph disabled) we have to display links to external pages as text links no matter what.
@mejo- mejo- added bug Something isn't working 29 feedback labels Mar 18, 2024
@mejo- mejo- added this to the Nextcloud 29 milestone Mar 18, 2024
@juliushaertl
Copy link
Member

As discussed in the call:

  • Text: Let's enable the fallback for link previews in the preview node type
  • Server: File a enhancement request for previews on public shares

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
29 feedback bug Something isn't working
Projects
Status: 📄 To do (~10 entries)
Development

No branches or pull requests

4 participants