Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better terminology for database tables from NC 30 on #5482

Open
max-nextcloud opened this issue Mar 13, 2024 · 0 comments
Open

Better terminology for database tables from NC 30 on #5482

max-nextcloud opened this issue Mar 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@max-nextcloud
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The current terminology, database structure and flow for sync have been inherited from the tiptap 1 sync mechanism. This is confusing.

Describe the solution you'd like

  • session -> connection: These are actually connections from one client to the server. They are temporary and when the client reconnects it gets a new connection.
  • document -> ydoc: This is actually the metadata for one ydoc evolving over time.
  • steps -> sync_messages: yjs messages to keep the ydoc in sync.

Using the same data formats for messages

  • Send one update message per request. (Generate it when sending the request).
  • Store one update message per database entry.
  • Send full document history as an update message including bits indicating its a sync update.
  • Store the full doc history in the messages table along other messages with a flag indicating its a full sync

Open questions

What do we do with awareness messages?

Describe alternatives you've considered

  • Keeping the names as they are - confusing
  • Creating new table and structure from scratch - I'd rather go incrementally - but might be worth a second thought.
@max-nextcloud max-nextcloud added the enhancement New feature or request label Mar 13, 2024
@max-nextcloud max-nextcloud changed the title Better terminology for sync tables from NC 30 on Better terminology for database tables from NC 30 on Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant