Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recording upload failed due to missing user #9905

Closed
nickvergessen opened this issue Jul 6, 2023 · 4 comments · Fixed by #12308
Closed

Recording upload failed due to missing user #9905

nickvergessen opened this issue Jul 6, 2023 · 4 comments · Fixed by #12308
Labels
Milestone

Comments

@nickvergessen
Copy link
Member

{
  "reqId": "UbsWs30yteDgbmrnEtC6",
  "level": 3,
  "time": "2023-07-06T10:26:14+00:00",
  "remoteAddr": "",
  "user": "--",
  "app": "no app in context",
  "method": "POST",
  "url": "//ocs/v2.php/apps/spreed/api/v1/recording/…/store",
  "message": "OCA\\Talk\\Controller\\RecordingController::store(): Argument #1 ($owner) must be of type string, null given, called in /…/lib/private/AppFramework/Http/Dispatcher.php on line 230 in file /…/apps/spreed/lib/Controller/RecordingController.php line 296",
  "userAgent": "Python-urllib/3.8",
  "version": "27.0.0.8",
  "exception": {
    "Exception": "Exception",
    "Message": "OCA\\Talk\\Controller\\RecordingController::store(): Argument #1 ($owner) must be of type string, null given, called in /…/lib/private/AppFramework/Http/Dispatcher.php on line 230 in file /…/apps/spreed/lib/Controller/RecordingController.php line 296",
    "Code": 0,
    "Trace": [
      {
        "file": "/…/lib/private/AppFramework/App.php",
        "line": 183,
        "function": "dispatch",
        "class": "OC\\AppFramework\\Http\\Dispatcher",
        "type": "->",
        "args": [
          [
            "OCA\\Talk\\Controller\\RecordingController"
          ],
          "store"
        ]
      },
      {
        "file": "/…/lib/private/Route/Router.php",
        "line": 315,
        "function": "main",
        "class": "OC\\AppFramework\\App",
        "type": "::",
        "args": [
          "OCA\\Talk\\Controller\\RecordingController",
          "store",
          [
            "OC\\AppFramework\\DependencyInjection\\DIContainer"
          ],
          [
            "v1",
            "",
            "ocs.spreed.Recording.store"
          ]
        ]
      },
      {
        "file": "/…/ocs/v1.php",
        "line": 64,
        "function": "match",
        "class": "OC\\Route\\Router",
        "type": "->",
        "args": [
          "/ocsapp/apps/spreed/api/v1/recording/5874971069/store"
        ]
      },
      {
        "file": "/…/ocs/v2.php",
        "line": 23,
        "args": [
          "/…/ocs/v1.php"
        ],
        "function": "require_once"
      }
    ],
    "File": "/…/lib/private/AppFramework/Http/Dispatcher.php",
    "Line": 169,
    "Previous": {
      "Exception": "TypeError",
      "Message": "OCA\\Talk\\Controller\\RecordingController::store(): Argument #1 ($owner) must be of type string, null given, called in /…/lib/private/AppFramework/Http/Dispatcher.php on line 230",
      "Code": 0,
      "Trace": [
        {
          "file": "/…/lib/private/AppFramework/Http/Dispatcher.php",
          "line": 230,
          "function": "store",
          "class": "OCA\\Talk\\Controller\\RecordingController",
          "type": "->",
          "args": [
            null
          ]
        },
        {
          "file": "/…/lib/private/AppFramework/Http/Dispatcher.php",
          "line": 137,
          "function": "executeController",
          "class": "OC\\AppFramework\\Http\\Dispatcher",
          "type": "->",
          "args": [
            [
              "OCA\\Talk\\Controller\\RecordingController"
            ],
            "store"
          ]
        },
        {
          "file": "/…/lib/private/AppFramework/App.php",
          "line": 183,
          "function": "dispatch",
          "class": "OC\\AppFramework\\Http\\Dispatcher",
          "type": "->",
          "args": [
            [
              "OCA\\Talk\\Controller\\RecordingController"
            ],
            "store"
          ]
        },
        {
          "file": "/…/lib/private/Route/Router.php",
          "line": 315,
          "function": "main",
          "class": "OC\\AppFramework\\App",
          "type": "::",
          "args": [
            "OCA\\Talk\\Controller\\RecordingController",
            "store",
            [
              "OC\\AppFramework\\DependencyInjection\\DIContainer"
            ],
            [
              "v1",
              "",
              "ocs.spreed.Recording.store"
            ]
          ]
        },
        {
          "file": "/…/ocs/v1.php",
          "line": 64,
          "function": "match",
          "class": "OC\\Route\\Router",
          "type": "->",
          "args": [
            "/ocsapp/apps/spreed/api/v1/recording/5874971069/store"
          ]
        },
        {
          "file": "/…/ocs/v2.php",
          "line": 23,
          "args": [
            "/…/ocs/v1.php"
          ],
          "function": "require_once"
        }
      ],
      "File": "/…/apps/spreed/lib/Controller/RecordingController.php",
      "Line": 296
    },
    "CustomMessage": "--"
  }
}
@nickvergessen
Copy link
Member Author

The same request also logged a POST Content-Length of 571447493 bytes exceeds the limit of 536870912 bytes at Unknown#0 So maybe that is why the owner was missing from the post data?

@danxuliu
Copy link
Member

danxuliu commented Jul 10, 2023

After some testing the missing owner seems to be indeed caused by exceeding the POST Content-Length. I have not digged into the Controller code to check exactly why, though.

Note that there is no missing owner if upload_max_filesize is exceeded but post_max_size is not (error logged as The uploaded file exceeds the upload_max_filesize directive in php.ini).

The missing owner is not related either to #9253 (which changed the library that sends the requests from the recording server to the Nextcloud server), it happens both with and without those changes.

@nickvergessen
Copy link
Member Author

On the instance that had the error both values are set to the same 512MB

@danxuliu
Copy link
Member

danxuliu commented Aug 1, 2023

On the instance that had the error both values are set to the same 512MB

In that case post_max_size hits first, so to speak, and the missing owner error occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants