Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix circular dependency with @nextcloud/vue-richtext #3834

Merged
merged 1 commit into from Feb 28, 2023
Merged

Fix circular dependency with @nextcloud/vue-richtext #3834

merged 1 commit into from Feb 28, 2023

Conversation

julien-nc
Copy link
Contributor

Use @nextcloud/vue-richtext 2.1.0-beta.6 which fixes the circular dependency by including @nextcloud/vue in its rollup package.

This made it impossible to import both @nextcloud/vue and @nextcloud/vue-richtext in the same script and caused rendering issues of @nextcloud/vue-richtext when used in @nextcloud/vue.

This is a temporary fix for things to work until @nextcloud/vue-richtext is merged in here.
refs #3812

@julien-nc
use @nextcloud/vue-richtext 2.1.0-beta.6 which fixes the circular dep…
d044e86 
…endency

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc added bug Something isn't working 3. to review Waiting for reviews labels Feb 28, 2023
@juliushaertl juliushaertl merged commit e156827 into master Feb 28, 2023
@juliushaertl juliushaertl deleted the fix/noid/bump-nc-vue-richtext-circular-dep branch February 28, 2023 16:53
@julien-nc julien-nc mentioned this pull request Feb 28, 2023
Merged
@julien-nc julien-nc added this to the 7.7.2 milestone Mar 1, 2023
@raimund-schluessler
Copy link
Contributor

For one of my apps I now see

ERROR in ./node_modules/@nextcloud/vue-richtext/dist/index.js 16072:15-67
Module not found: Error: Can't resolve '@nextcloud/calendar-js' in '/home/runner/work/inventory/inventory/node_modules/@nextcloud/vue-richtext/dist'
resolve '@nextcloud/calendar-js' in '/home/runner/work/inventory/inventory/node_modules/@nextcloud/vue-richtext/dist'

after trying to update to nextcloud/vue@7.7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@mejo- mejo- mejo- approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
7.7.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@julien-nc @raimund-schluessler @juliushaertl @mejo-