NcSelect: Only hide search input if disabled and an element was selected #3833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
susnux
requested review from
raimund-schluessler,
Chartman123,
Pytal and
marcoambrosini
raimund-schluessler
approved these changes
Feb 28, 2023
Chartman123
approved these changes
Feb 28, 2023
…selected This fixes a regression where the placeholder text is not shown if configured to be not searchable. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnux
force-pushed
the
fix/ncselect-placeholder
branch
from
259b44c
to
c350a66
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression where the placeholder text is not shown if
NcSelectis configured to be not searchable, in this case the input element was hidden but this also hides the placeholder.