Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rounded select dropdown options #3818

Merged
merged 1 commit into from Feb 27, 2023
Merged

Rounded select dropdown options #3818

merged 1 commit into from Feb 27, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Feb 25, 2023

Before After
image image

@Pytal Pytal added 3. to review Waiting for reviews design Design, UX, interface and interaction design labels Feb 25, 2023
@Pytal Pytal added this to the 7.8.0 milestone Feb 25, 2023
@Pytal Pytal self-assigned this Feb 25, 2023
@Pytal Pytal mentioned this pull request Feb 25, 2023
Closed
3 tasks
raimund-schluessler
raimund-schluessler approved these changes Feb 25, 2023
View reviewed changes
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works well, with the timezone picker as well:
Screenshot 2023-02-25 at 08-01-50 Nextcloud Vue Style Guide

I just have a minor nitpick 🙂

@raimund-schluessler raimund-schluessler added the feature: select Related to the NcSelect* components label Feb 25, 2023
@raimund-schluessler raimund-schluessler linked an issue Feb 25, 2023 that may be closed by this pull request
Adjust NcSelect styling #3798
Closed
3 tasks
nimishavijay
nimishavijay approved these changes Feb 25, 2023
View reviewed changes
Copy link

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks way better now and completely agree with the note from @raimund-schluessler, nice catch! :)

jancborchardt
jancborchardt approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! :) Just see @raimund-schluessler's notes

@Pytal @raimund-schluessler
Rounded select dropdown options
677bdf2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@raimund-schluessler raimund-schluessler merged commit d59426a into master Feb 27, 2023
@raimund-schluessler raimund-schluessler deleted the enh/select-design branch February 27, 2023 12:33
@julien-nc julien-nc mentioned this pull request Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@nimishavijay nimishavijay nimishavijay approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design feature: select Related to the NcSelect* components
Projects
None yet
Milestone
7.8.0
Development

Successfully merging this pull request may close these issues.

Adjust NcSelect styling
4 participants
@Pytal @jancborchardt @raimund-schluessler @nimishavijay