Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show round corners for scrolling NcActions #3797

Merged
merged 1 commit into from Feb 20, 2023
Merged

Show round corners for scrolling NcActions #3797

merged 1 commit into from Feb 20, 2023

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Feb 20, 2023 •
edited

The scrollbar in an NcActions component makes the right top and bottom corners square. This PR fixes it.

Before After
Screenshot 2023-02-20 at 14-03-36 Nextcloud Vue Style Guide Screenshot 2023-02-20 at 14-09-32 Nextcloud Vue Style Guide

@raimund-schluessler
Show round corners for scrolling NcActions
a6482aa 
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler marked this pull request as ready for review February 20, 2023 13:10
@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components labels Feb 20, 2023
@raimund-schluessler raimund-schluessler added this to the 7.7.0 milestone Feb 20, 2023
jancborchardt
jancborchardt approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks great! :)

@GretaD
Copy link
Contributor

GretaD commented Feb 20, 2023

Nice! In the "after" screenshot, the top right corner is still a sharp corner if the scrollbar is up there, is it possible to fix that too? (E.g. by the scrollbar being inside the container?) It's also fine if not, this is already an improvement. :)

no its not, its an optical illusion because of the shade of the popup :) its a round one

@raimund-schluessler raimund-schluessler merged commit f688b22 into master Feb 20, 2023
@raimund-schluessler raimund-schluessler deleted the fix/noid/actions-scroll-border branch February 20, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@GretaD GretaD GretaD approved these changes

@susnux susnux Awaiting requested review from susnux

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: actions Related to the actions components
Projects
None yet
Milestone
7.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raimund-schluessler @GretaD @jancborchardt @ChristophWurst