Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define global focus trap #3478

Merged
merged 1 commit into from Nov 15, 2022
Merged

Define global focus trap #3478

merged 1 commit into from Nov 15, 2022

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Nov 15, 2022 •
edited

@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews high High priority labels Nov 15, 2022
@skjnldsv skjnldsv self-assigned this Nov 15, 2022
@skjnldsv skjnldsv requested review from artonge, Pytal and szaimen and removed request for a team November 15, 2022 08:49
@skjnldsv
Define global focus trap
0af56e8 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
szaimen
szaimen approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@juliushaertl

This comment was marked as outdated.

Sign in to view
@juliushaertl

This comment was marked as outdated.

Sign in to view
juliushaertl
juliushaertl approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works with text/viewer

@juliushaertl juliushaertl mentioned this pull request Nov 15, 2022
Closed
@skjnldsv skjnldsv merged commit 37c7332 into master Nov 15, 2022
@skjnldsv skjnldsv deleted the fix/focus-trap branch November 15, 2022 13:03
@skjnldsv skjnldsv mentioned this pull request Nov 15, 2022
Merged
@JohannesGGE JohannesGGE mentioned this pull request Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge left review comments

@juliushaertl juliushaertl juliushaertl approved these changes

@szaimen szaimen szaimen approved these changes

@vinicius73 vinicius73 Awaiting requested review from vinicius73

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working high High priority
Projects
None yet
Milestone
No milestone
4 participants
@skjnldsv @juliushaertl @artonge @szaimen