Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix password_policy fallback handling #3408

Merged
merged 1 commit into from Nov 2, 2022
Merged

Fix password_policy fallback handling #3408

merged 1 commit into from Nov 2, 2022

Conversation

nickvergessen
Copy link
Contributor

The defined fallback is only affecting when no core=>capabilities is there. But that is pretty unlikely while the password_policy entry can be missing often (app not installed, unit tests, ...)

Also null vs. undefined gives different results:
https://github.com/nextcloud/nextcloud-vue/blob/0204f6dd86ad16e9b57d8c5915ee15672d4a5e5a/src/components/NcPasswordField/NcPasswordField.vue#L354-L359

Fixes the failing JS unit test in: nextcloud/spreed#8213

@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews feature: input-field Covering the InputField, TextField, ... labels Oct 31, 2022
@nickvergessen nickvergessen added this to the 7.0.2 milestone Oct 31, 2022
@nickvergessen nickvergessen mentioned this pull request Oct 31, 2022
Merged
2 tasks
danxuliu
danxuliu approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but code looks good.

Should the handling of null and undefined be unified?

@nickvergessen
Fix password_policy fallback handling
d8fc2a8 
The defined fallback is only affecting when no core=>capabilities is there.
But that is pretty unlikely, while the password_policy entry can be missing easily.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/fix-password-policy-fallback-handling branch from 0204f6d to d8fc2a8 Compare November 2, 2022 07:20
@nickvergessen
Copy link
Contributor Author

Should the handling of null and undefined be unified?

With the current approach they are.

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 2, 2022
@skjnldsv skjnldsv merged commit ecbac17 into master Nov 2, 2022
@skjnldsv skjnldsv deleted the bugfix/noid/fix-password-policy-fallback-handling branch November 2, 2022 08:01
@skjnldsv skjnldsv mentioned this pull request Nov 15, 2022
Merged
@skjnldsv skjnldsv modified the milestones: 7.0.2, 7.1.0 Nov 16, 2022
@nickvergessen
Copy link
Contributor Author

(╯°□°)╯︵ ┻━┻

@nickvergessen
Copy link
Contributor Author

/backport to stable7

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@danxuliu danxuliu danxuliu approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feature: input-field Covering the InputField, TextField, ...
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickvergessen @skjnldsv @danxuliu