Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiselect background color spilling outside the component #3252

Merged
merged 1 commit into from Sep 14, 2022
Merged

Fix multiselect background color spilling outside the component #3252

merged 1 commit into from Sep 14, 2022

Conversation

ChristophWurst
Copy link
Contributor

If you put the multiselect somewhere other than an element with the main background color, it looked weird.

Before After
Bildschirmfoto vom 2022-09-14 11-50-55 Bildschirmfoto vom 2022-09-14 11-53-22

@ChristophWurst
Fix multiselect background color spilling outside the component
0de278b 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews design Design, UX, interface and interaction design labels Sep 14, 2022
@ChristophWurst ChristophWurst added this to the 7.0.0 milestone Sep 14, 2022
@ChristophWurst ChristophWurst self-assigned this Sep 14, 2022
@ChristophWurst ChristophWurst mentioned this pull request Sep 14, 2022
Merged
4 tasks
GretaD
GretaD approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@ChristophWurst ChristophWurst merged commit 1055f92 into master Sep 14, 2022
@ChristophWurst ChristophWurst deleted the fix/multiselect-background-color branch September 14, 2022 10:29
@ChristophWurst ChristophWurst mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD GretaD approved these changes

@szaimen szaimen szaimen approved these changes

@mejo- mejo- Awaiting requested review from mejo-

@artonge artonge Awaiting requested review from artonge

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChristophWurst @GretaD @szaimen