Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a word puzzle in NcDashboardWidget component #3225

Merged
merged 1 commit into from Sep 12, 2022
Merged

Fix a word puzzle in NcDashboardWidget component #3225

merged 1 commit into from Sep 12, 2022

Conversation

CarlSchwan
Copy link
Contributor

Instead of having a prop that allows customizing one part of a sentence, use a prop to allow changing the full sentences.

Part of the fix for nextcloud/activity#919

This an API break so only for nc-7

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Sep 12, 2022
@CarlSchwan CarlSchwan added this to the 7.0.0 milestone Sep 12, 2022
@CarlSchwan CarlSchwan self-assigned this Sep 12, 2022
@raimund-schluessler
Copy link
Contributor

Need to extract the l10n changes.

Also, nc6 was not released yet, so we can still backport breaking changes as well, I would say.

@raimund-schluessler
Copy link
Contributor

/backport to stable6

julien-nc
julien-nc approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Sorry about that 😁

@CarlSchwan
Fix a word puzzle in NcDashboardWidget component
5b58373 
Instead of having a prop that allows customizing one part of a sentence, use
a prop to allow changing the full sentences.

Fix nextcloud/activity#919

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan merged commit b186ec4 into master Sep 12, 2022
@CarlSchwan CarlSchwan deleted the fix-world-puzzle branch September 12, 2022 09:59
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 12, 2022
Merged
@nickvergessen
Copy link
Contributor

🚀

@Jerome-Herbinet
Copy link
Member

Hello,
I've noticed that the translated wording isn't used in front-end ; is the issue actually fixed ?
My instance is Nextcloud 25.0.3.

thumb-Clipboard - 9 février 2023 11_44

2023-02-09_11-53

Cc : @nickvergessen @julien-nc @raimund-schluessler

@nickvergessen
Copy link
Contributor

Each app needs to adapt it manually.

@nickvergessen
Copy link
Contributor

And the activity app is still using the legacy component:
https://github.com/nextcloud/activity/blob/master/package.json#L84

@Jerome-Herbinet Jerome-Herbinet mentioned this pull request Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@julien-nc julien-nc julien-nc approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@CarlSchwan CarlSchwan

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@CarlSchwan @raimund-schluessler @nickvergessen @Jerome-Herbinet @julien-nc