Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right-align nav item utils #3178

Merged
merged 1 commit into from Sep 6, 2022
Merged

Conversation

ChristophWurst
Copy link
Contributor

Follow-up to #3165.

Before After
Bildschirmfoto vom 2022-09-05 19-42-24 Bildschirmfoto vom 2022-09-05 19-39-01

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added bug Something isn't working 3. to review Waiting for reviews design Design, UX, interface and interaction design labels Sep 5, 2022
@ChristophWurst ChristophWurst added this to the 7.0.0 milestone Sep 5, 2022
@ChristophWurst ChristophWurst self-assigned this Sep 5, 2022
@ChristophWurst
Copy link
Contributor Author

/backport to stable6

@jancborchardt
Copy link
Contributor

Actually seems a bit too far off to the right now. Better would be to right-align it with the right side of the more-actions icon?

Experimented with 12px margin-right for the counter instead of 2px – but note this needs to be reduced again on hover/focus.

After this PR With increased margin-right
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants