Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Modal closing #3066

Merged
merged 1 commit into from Aug 18, 2022
Merged

Fix Modal closing #3066

merged 1 commit into from Aug 18, 2022

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Aug 18, 2022 •
edited

@skjnldsv
Fix Modal closing
54e4062 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 3. to review Waiting for reviews high High priority regression Regression of a previous working feature feature: modal Related to the modal component labels Aug 18, 2022
@skjnldsv skjnldsv added this to the 6.0.0 milestone Aug 18, 2022
@skjnldsv skjnldsv self-assigned this Aug 18, 2022
@skjnldsv skjnldsv requested review from PVince81, artonge and szaimen and removed request for a team August 18, 2022 17:44
This was referenced Aug 18, 2022
Merged
Merged
nickvergessen
nickvergessen approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opsy

@skjnldsv
Copy link
Contributor Author

Damnit, it re-requested, sorry Joas

@raimund-schluessler raimund-schluessler merged commit 1419a4f into master Aug 18, 2022
@raimund-schluessler raimund-schluessler deleted the fix/Modal-closing branch August 18, 2022 19:43
@skjnldsv skjnldsv mentioned this pull request Aug 23, 2022
Merged
@GretaD GretaD mentioned this pull request Aug 23, 2022
Merged
5 tasks
@raimund-schluessler raimund-schluessler mentioned this pull request Aug 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@Pytal Pytal Pytal approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@PVince81 PVince81 Awaiting requested review from PVince81

@artonge artonge Awaiting requested review from artonge

@szaimen szaimen Awaiting requested review from szaimen

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews feature: modal Related to the modal component high High priority regression Regression of a previous working feature
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skjnldsv @nickvergessen @raimund-schluessler @Pytal